Merge ~wxl/kubuntu-packaging/+git/kppp:kubuntu_unstable into ~kubuntu-packagers/kubuntu-packaging/+git/kppp:kubuntu_unstable
| Status: | Merged |
|---|---|
| Merged at revision: | 18d941c2b30d63518a3889ca391d2976820d0ac6 |
| Proposed branch: | ~wxl/kubuntu-packaging/+git/kppp:kubuntu_unstable |
| Merge into: | ~kubuntu-packagers/kubuntu-packaging/+git/kppp:kubuntu_unstable |
| Diff against target: |
23 lines (+2/-2) 2 files modified
debian/kppp.NEWS (+1/-1) debian/kppp.README.Debian (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kubuntu Packagers | Pending | ||
|
Review via email:
|
|||
Description of the change
Fixes version numbers mentioned in kppp.{NEWS,
This lintian tag occurs when NEWS.Debian mentions a version number that can't be found in the changelog. They both mention 4:4.8.4-3, which is not to be found. Both of these files refer to kppp 4:4.8.4-3. Interestingly, the package wasn't actually known as kppp back then. Look at the changelog and you'll find a 4:4.8.4-1, but it's kdenetwork.
Debian is plagued by the same problem: https:/
As is Neon: https:/
That said, it made sense to just change the version to match the latest version closest to the kppp 4:4.8.4-3 (kdenetwork 4:4.8.4-1). Problem solved.
On the other hand…
What's really interesting is that this commit (b5b4feb) is from 9 September 2013 which corresponds to the kppp 4:4.11.1-1 version in the changelog. This was to deal with an upstream split and ended up producing a new source package kppp, which is what we deal with now. kppp used to be a part of the kdenetwork package (https:/
Trimming off all the kppp entries from a fresh Neon kppp changelog, I find some differences, but mainly a lot of stuff missing:
http://
So maybe the bigger problem would be to add all the changelog entries back. Well, kdenetwork built a lot of different packages. So maybe cherry-picking would make more sense.
On the other hand, at least in relation to 4:4.8.4-3, there's no reason why it shouldn't be included. As you can see, it made changes that (outside of the changelog entry), still exist in the current codebase:
http://
tl;dr, the fix works, albeit it being a bit janky, but this tends to reveal a larger problem that seems to have been all but ignored for 3 years.
| Clive Johnston (clivejo) wrote | # |
| ԜаӀtеr Ⅼарсһуnѕkі (wxl) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Do you think that these items are still needed? Given that the NEWS file is signed off by Maxy in June 2013. Kinda sounds like old news to me :)
Also, we usually also include a changelog entry just saying what was done in your commit.