Merge ~woodrow-shen/ubiquity/+git/add-bitlocker-support:enhance-ux-for-windows into ubiquity:master
| Status: | Rejected |
|---|---|
| Rejected by: | Iain Lane |
| Proposed branch: | ~woodrow-shen/ubiquity/+git/add-bitlocker-support:enhance-ux-for-windows |
| Merge into: | ubiquity:master |
| Diff against target: |
64 lines (+27/-0) 3 files modified
debian/changelog (+6/-0) ubiquity/misc.py (+18/-0) ubiquity/parted_server.py (+3/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Iain Lane (community) | Disapprove | ||
| Julian Andres Klode (community) | Needs Information | ||
| Ubuntu Installer Team | Pending | ||
|
Review via email:
|
|||
Description of the change
The merge proposal for Improve User experience of Windows Users for Focal[1]
Changelog:
* Add detection of BitLocker partitions.
According to design spec[2], "Turn off BitLocker" dialogue will be shown during "Installation Type" (i.e. try to resize BitLocker partition in this case) if BitLocker partitions existed. It means BitLocker detection must be done before "Installation Type". To deal with the problem, there is a new function implemented by misc.py to call blkid with specified argument, and it checks if "BitLocker " is tagged by TYPE, and then this info is updated into partition caches.
[1] https:/
[2] https:/
| Woodrow Shen (woodrow-shen) wrote | # |
| Dimitri John Ledkov (xnox) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Added some comments. So far this adds detection, but it seems questionable if this is enough at the right place to enable further work.