eCryptfs

Merge lp://staging/~wlxing/ecryptfs/fix-command-termination into lp://staging/ecryptfs

  1. fix-command-termination
  2. Merge into trunk
Proposed by Jason Xing
Status: Merged
Merge reported by: Jason Xing
Merged at revision: not available
Proposed branch: lp://staging/~wlxing/ecryptfs/fix-command-termination
Merge into: lp://staging/ecryptfs
Diff against target: 24 lines (+2/-1)
2 files modified
debian/changelog (+2/-0)
src/utils/ecryptfs-recover-private (+0/-1)
To merge this branch: bzr merge lp://staging/~wlxing/ecryptfs/fix-command-termination
Reviewer Review Type Date Requested Status
Tyler Hicks Approve
Review via email: mp+325359@code.staging.launchpad.net

Description of the change

src/utils/ecryptfs-recover-private: Prevent ecryptfs-recover-private command is terminated because of printing warnings. So just get rid of line "exit 1" in the warn() function.

To post a comment you must log in.
Revision history for this message
Tyler Hicks (tyhicks) wrote :

Nice catch!

I've dropped the entry that you added to debian/changelog since this is fixing a bug that I introduced in the development cycle. We only need to put user facing changes into debian/changelog and fixing a bug that was introduced after the last official release is not typically user facing.

Thanks again for catching and fixing my mistake here. :)

review: Approve
Revision history for this message
Jason Xing (wlxing) wrote :

I got it! Now I learn more about the debian/changelog. Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches