Merge lp://staging/~widelands-media-dev/widelands-media/cleanup-world into lp://staging/widelands-media

Proposed by GunChleoc
Status: Merged
Merged at revision: 233
Proposed branch: lp://staging/~widelands-media-dev/widelands-media/cleanup-world
Merge into: lp://staging/widelands-media
Diff against target: 9237 lines (+1/-4)
1 file modified
graphics/world/README.TXT (+1/-4)
To merge this branch: bzr merge lp://staging/~widelands-media-dev/widelands-media/cleanup-world
Reviewer Review Type Date Requested Status
Benedikt Straub diff Approve
Review via email: mp+379579@code.staging.launchpad.net

Commit message

Remove png export files from world and restructure world directories

To post a comment you must log in.
Revision history for this message
Benedikt Straub (nordfriese) wrote :

For many of the bobs, we have only the "idle" and one "walk" blender file. So if you remove the PNGs, it would be very important IMHO to add information to the readme how to export the walkanims for all six directions, and which scale exactly is appropriate for rendering.

As far as I know many of the older blend files used scripts for rendering directional anims which may be incompatible with later blender versions so I worry whether they can really be fully rerendered when needed

Revision history for this message
GunChleoc (gunchleoc) wrote :

We already have them rendered in Widelands, so I don't see why we need them twice ;)

I have tested the render scripts in Blender 2.79b and they still work. They're a bit buggy for player color where they change something in the Blender file after the render, but this is irrelevant for the world.

Revision history for this message
Benedikt Straub (nordfriese) wrote :

How exactly are those scripts used? I always get either no result at all or an error like:

bpy.ops.text.run_script()
  File "/home/benedikt/wl/widelands-media/graphics/worlds/any_world/bobs/europ_animal_blends/fox/fox_walk.blend/menu.py", line 294
    print prefix
               ^
SyntaxError: Missing parentheses in call to 'print'
location: <unknown location>:-1
Python script fail, look in the console for now...

Revision history for this message
GunChleoc (gunchleoc) wrote :

I have never had this problem in any Blender version. I have used a few over the years, bot under Windows and Linux.

I just retested innerWorker.py with fox_walk.blend and Blender 2.79b, and it's working fine.

On usage, I once managed to grab AlexiaDeath on IRC for help and then took a screenshot

https://www.widelands.org/wiki/GraphicsDevelopment/#the-scripts

For the fox, of course no tick for the player colors.

Revision history for this message
Benedikt Straub (nordfriese) wrote :

Ah now I see my mistake :)
Rerendering the bobs using these scripts now works for me. No reason against cleaning up the media repo then :)

review: Approve (diff)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Excellent :)

Thanks for the review!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: