Merge lp://staging/~widelands-dev/widelands/fsmenu_fullscreen_4_options into lp://staging/widelands

Code looks OK (as far as I can grasp it).
One nit inline.

I will however compile this and do some stress tesing on OSX with a dual Monitor layout.

Will/Hsould the 'f' (or some) shortcut be supported inside the menu?

Clang complains:

fsmenu_fullscreen_4_options/src/ui_fsmenu/options.cc:139:25: error: field
      'column_width_' is uninitialized when used here [-Werror,-Wuninitialized]
                        column_width_ / 2,

fsmenu_fullscreen_4_options/src/ui_fsmenu/options.cc:145:27: error: field
      'column_width_' is uninitialized when used here [-Werror,-Wuninitialized]
                          column_width_ / 2,

Where should that column_width_ be set?

Thanks for the clang output - I replaced it with a constant. It is set later in the layout() function. I also did my best on your nit :)

And yes, this is about the f button.

Should the overall size not be correct with multiscreen setups, that will be a separate bug.

OK, I tryed this with a two Monitor layout on OSX.
Main Monitor Full-HD plus the "normal" Laptop Display.

Works for all Tabs using f back and forth.

Small Problem; when on the Second Scrren the normalw window
moves quite quite a bit to the right, but still is visbile.

I think we need at least a test on Wind and some Linux,
bet with mutiple Monitors, if possible.

I get this carsh now (which I had in trunk, too)
Assertion failed: (lborder_ + rborder_ <= w_), function get_inner_w, file /Users/klaus/develop/widelands-repo/fsmenu_fullscreen_4_options/src/ui_basic/panel.h, line 184.
Abort trap: 6

THis happend when I start widelands directly into the fullscreen mode and then
try to open the internet panel.

Both of these problems are happening in trunk already, so this needs a bug report for trunk, not for this branch.

This bug doesn't implement the size change, it only relayouts the contents of the Options panel and adjust some bits of the toolkit to make this happen.

Continuous integration builds have changed state:

Travis build 1751. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fsmenu_fullscreen_4_options-1591.

Bunnybot encountered an error while working on this merge proposal:

('The read operation timed out',)

Continuous integration builds have changed state:

Travis build 1751. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fsmenu_fullscreen_4_options-1591.

Bunnybot encountered an error while working on this merge proposal:

HTTP Error 500: Internal Server Error

Continuous integration builds have changed state:

Travis build 1751. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fsmenu_fullscreen_4_options-1591.

Bunnybot encountered an error while working on this merge proposal:

('The read operation timed out',)

Continuous integration builds have changed state:

Travis build 1751. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fsmenu_fullscreen_4_options-1591.

Works here on Linux with multi monitor setup.

Hasi50 approved the code for this branch in IRC.

@bunnybot merge