Merge lp://staging/~widelands-dev/widelands/frisian_balancing_worldsavior_201809 into lp://staging/widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8871
Proposed branch: lp://staging/~widelands-dev/widelands/frisian_balancing_worldsavior_201809
Merge into: lp://staging/widelands
Diff against target: 123 lines (+11/-11)
7 files modified
data/tribes/buildings/productionsites/frisians/aqua_farm/init.lua (+2/-2)
data/tribes/buildings/productionsites/frisians/tavern/init.lua (+1/-1)
data/tribes/buildings/trainingsites/frisians/training_arena/init.lua (+4/-4)
data/tribes/buildings/trainingsites/frisians/training_camp/init.lua (+1/-1)
data/tribes/workers/frisians/baker/init.lua (+1/-1)
data/tribes/workers/frisians/blacksmith/init.lua (+1/-1)
data/tribes/workers/frisians/brewer/init.lua (+1/-1)
To merge this branch: bzr merge lp://staging/~widelands-dev/widelands/frisian_balancing_worldsavior_201809
Reviewer Review Type Date Requested Status
Benedikt Straub diff Approve
Review via email: mp+355907@code.staging.launchpad.net

Commit message

Various balancing changes for Frisian production.

To post a comment you must log in.
Revision history for this message
Benedikt Straub (nordfriese) wrote :

I´m fine with the changes to training camp and tavern.
Having the aqua farm consume just 1 water is illogical, because the water is needed to fill a pond. It should be at least 2 water per cycle.

I am *very* unhappy about the experience changes, since large experience demands are part of the tribe´s character. Just 10 XP for the brewer?!? That´s much to few, and he must need more XP than the baker. Perhaps lowering the baker from 16 to 13 (that´s already very few!) and the brewer from 19 to 15? No more than that please. And the decrease for the blacksmith is _far_ too great as well. Perhaps to 18 or even 17, but not more.

review: Needs Fixing
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4084. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/435511178.
Appveyor build 3880. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_frisian_balancing_worldsavior_201809-3880.

Revision history for this message
Benedikt Straub (nordfriese) wrote :

All right, I can agree with that

review: Approve (diff)
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4092. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/437007517.
Appveyor build 3888. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_frisian_balancing_worldsavior_201809-3888.

Revision history for this message
GunChleoc (gunchleoc) wrote :

@bunnybot merge

Revision history for this message
bunnybot (widelandsofficial) wrote :

Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways.

Travis build 4092. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/437007517.

Revision history for this message
GunChleoc (gunchleoc) wrote :

apt-get install failed

@bunnybot merge force

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: