Merge lp://staging/~widelands-dev/widelands/enemysites_check_delay_used_before_initialized into lp://staging/widelands

Proposed by Jukka Pakarinen
Status: Merged
Merged at revision: 8506
Proposed branch: lp://staging/~widelands-dev/widelands/enemysites_check_delay_used_before_initialized
Merge into: lp://staging/widelands
Diff against target: 11 lines (+1/-0)
1 file modified
src/ai/defaultai.cc (+1/-0)
To merge this branch: bzr merge lp://staging/~widelands-dev/widelands/enemysites_check_delay_used_before_initialized
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+334287@code.staging.launchpad.net

Description of the change

DefaultAI::enemysites_check_delay_ variable is not initialized before it is used.
The fix in the branch fixes the bug 1734544.

To post a comment you must log in.
Revision history for this message
TiborB (tiborb95) wrote :

As discussed in bug, this value is wait time between two checks, so I suggest bit higher starting value. 30 would be fine...

Revision history for this message
Jukka Pakarinen (flegu) wrote :

Ok, I change the value!

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks, let's have it!

@bunnybot merge

review: Approve
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 2858. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/307569921.
Appveyor build 2668. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_enemysites_check_delay_used_before_initialized-2668.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: