Merge lp://staging/~widelands-dev/widelands/bug-1690649-netclient into lp://staging/widelands

Proposed by Notabilis
Status: Merged
Merged at revision: 8358
Proposed branch: lp://staging/~widelands-dev/widelands/bug-1690649-netclient
Merge into: lp://staging/widelands
Diff against target: 34 lines (+14/-10)
1 file modified
src/network/internet_gaming.cc (+14/-10)
To merge this branch: bzr merge lp://staging/~widelands-dev/widelands/bug-1690649-netclient
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+324129@code.staging.launchpad.net

Description of the change

This branch fixes a segfault when the metaserver closed the connection to the client. The bug triggers most of the time when you are logged in to the metaserver with one widelands instance and tries to log in with a second one.

The problem was that ... someone ;-) ... overlooked that handle_packet() can close the connection.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 2199. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/232965289.
Appveyor build 2034. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1690649_netclient-2034.

Revision history for this message
GunChleoc (gunchleoc) wrote :

LGTM :)

@bunnybot merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: