Merge lp://staging/~widelands-dev/widelands/bug-1668052-fix-multiselect into lp://staging/widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8335
Proposed branch: lp://staging/~widelands-dev/widelands/bug-1668052-fix-multiselect
Merge into: lp://staging/widelands
Diff against target: 86 lines (+6/-23)
2 files modified
src/ui_basic/table.cc (+6/-21)
src/ui_basic/table.h (+0/-2)
To merge this branch: bzr merge lp://staging/~widelands-dev/widelands/bug-1668052-fix-multiselect
Reviewer Review Type Date Requested Status
SirVer Approve
Review via email: mp+320760@code.staging.launchpad.net

Commit message

Fixed multiselect with shift in tables:
- Send selected signal when selecting with shift.
- More elegant way of detecting ctrl and shift presses.

Description of the change

The savegame details etc are now updated when selecting with shift.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 2060. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/214134048.
Appveyor build 1895. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1668052_fix_multiselect-1895.

Revision history for this message
SirVer (sirver) wrote :

Tested & works. Code LGTM and is even a valid simplification (since we no longer support replaying input events).

@bunnybot merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: