Merge lp://staging/~widelands-dev/widelands/bug-1658456-quantity-empire-soldier into lp://staging/widelands

Proposed by Notabilis
Status: Merged
Merged at revision: 8281
Proposed branch: lp://staging/~widelands-dev/widelands/bug-1658456-quantity-empire-soldier
Merge into: lp://staging/widelands
Diff against target: 12 lines (+1/-1)
1 file modified
src/logic/playercommand.cc (+1/-1)
To merge this branch: bzr merge lp://staging/~widelands-dev/widelands/bug-1658456-quantity-empire-soldier
Reviewer Review Type Date Requested Status
SirVer Approve
Review via email: mp+317026@code.staging.launchpad.net

Description of the change

Fixed bug that the empire soldier target quantity could not be changed. Turned out to be a simple copy&paste bug: The worker id was compared against the known ware ids. The carrier animals and the other soldiers just got lucky and were accepted since there exists wares with the same id.

To post a comment you must log in.
Revision history for this message
SirVer (sirver) wrote :

Nic find!

@bunnybot merge

review: Approve
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1927. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/200615715.
Appveyor build 1762. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1658456_quantity_empire_soldier-1762.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: