widelands

Merge lp://staging/~widelands-dev/widelands/bug-1647033-immovable-packet-no into lp://staging/widelands

bug-1647033-immovable-packet-no
Merge into trunk

Proposed by GunChleoc on 2016-12-06

Status:

Merged

Merged at revision:

8210

Proposed branch:

lp://staging/~widelands-dev/widelands/bug-1647033-immovable-packet-no

Merge into:

lp://staging/widelands

Diff against target:

50 lines (+15/-4)

1 file modified

src/logic/map_objects/immovable.cc (+15/-4)

To merge this branch:

bzr merge lp://staging/~widelands-dev/widelands/bug-1647033-immovable-packet-no

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
toptopple (community)		2016-12-06	Approve on 2016-12-08
Review via email: mp+312530@code.staging.launchpad.net

Commit message

Immovables now have a dynamic packet number, so maps will still load with Build 19: The packet number is only increased if the immovable has a former building.

Revision history for this message

bunnybot (widelandsofficial) wrote on 2016-12-06:

Continuous integration builds have changed state:

Travis build 1719. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/181581877.
Appveyor build 1559. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1647033_immovable_packet_no-1559.

Revision history for this message

toptopple (7010622-q-deactivatedaccount) wrote on 2016-12-08:

I could create a stable version of Gold Rush (online as version 1.2) with this branch and it loads into B19. Noteworthy, the save games of later versions still report the same error when loaded in B19. Not necessarily a problem. Savegames probably will grow incompatible anyway soon, so it's not worth fixing this part.

review: Approve

Revision history for this message

GunChleoc (gunchleoc) wrote on 2016-12-08:

Thanks for testing! Savegames as a rule aren't backwards compatible, only forwards compatible. The important thing is that maps can be loaded with older versions :)

@bunnybot merge

Revision history for this message

SirVer (sirver) wrote on 2016-12-10:

All other gold rush maps have been deleted, so the bug should not have any more impact.