python-oops-tools

Merge lp://staging/~wgrant/python-oops-tools/new-sqlparse into lp://staging/python-oops-tools

  1. new-sqlparse
  2. Merge into trunk
Proposed by William Grant
Status: Merged
Approved by: William Grant
Approved revision: 33
Merged at revision: 33
Proposed branch: lp://staging/~wgrant/python-oops-tools/new-sqlparse
Merge into: lp://staging/python-oops-tools
Diff against target: 12 lines (+1/-1)
1 file modified
versions.cfg (+1/-1)
To merge this branch: bzr merge lp://staging/~wgrant/python-oops-tools/new-sqlparse
Reviewer Review Type Date Requested Status
William Grant (community) code Approve
Review via email: mp+98950@code.staging.launchpad.net

Commit message

Upgrade sqlparse to 0.1.3 to get some crash fixes.

Description of the change

We currently use sqlparse 0.1.2, which crashes when reindenting some odd SQL:

>>> sqlparse.format('SELECT CASE (foo) WHEN 0 THEN 1 END', reindent=True)
u'SELECT CASE (foo)\n WHEN 0 THEN 1\n END'
>>> sqlparse.format('SELECT CASE(foo) WHEN 0 THEN 1 END', reindent=True)
Traceback (most recent call last):
  File "<console>", line 1, in <module>

This branch just upgrades us to 0.1.3, which fixes this particular issue.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: