Merge lp://staging/~wgrant/launchpad/transitionToTarget-validate_target into lp://staging/launchpad
Proposed by
William Grant
| Status: | Merged |
|---|---|
| Merged at revision: | 13529 |
| Proposed branch: | lp://staging/~wgrant/launchpad/transitionToTarget-validate_target |
| Merge into: | lp://staging/launchpad |
| Prerequisite: | lp://staging/~wgrant/launchpad/sensible-validate_target |
| Diff against target: |
125 lines (+49/-9) 4 files modified
lib/lp/bugs/model/bugtask.py (+12/-7) lib/lp/bugs/model/tests/test_bugtask.py (+26/-0) lib/lp/bugs/stories/webservice/xx-bug.txt (+8/-2) lib/lp/registry/browser/tests/test_milestone.py (+3/-0) |
| To merge this branch: | bzr merge lp://staging/~wgrant/launchpad/transitionToTarget-validate_target |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Steve Kowalik (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
transitionToTarget now calls validate_target, and only unsets the milestone once the transition is verified.
Description of the change
This branch extends transitionToTarget to call validate_target in addition to its existing checks. This brings it into line with the validation performed by BugTaskEditView. A couple of tests needed fixing to comply with these restrictions: test_milestone and xx-bug.txt attempted to move targets to unpublished packages.
transitionToTarget also no longer unsets the milestone unless the transition checks succeed.
To post a comment you must log in.
Revision history for this message
| Steve Kowalik (stevenk) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
