Merge lp://staging/~wgrant/launchpad/sqlbase-E-strings into lp://staging/launchpad

Proposed by William Grant
Status: Merged
Merged at revision: 17381
Proposed branch: lp://staging/~wgrant/launchpad/sqlbase-E-strings
Merge into: lp://staging/launchpad
Diff against target: 414 lines (+53/-53)
4 files modified
lib/lp/bugs/model/tests/test_bugtasksearch.py (+34/-34)
lib/lp/services/database/sqlbase.py (+12/-12)
lib/lp/services/webapp/tests/test_batching.py (+5/-5)
lib/sqlobject/__init__.py (+2/-2)
To merge this branch: bzr merge lp://staging/~wgrant/launchpad/sqlbase-E-strings
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+250263@code.staging.launchpad.net

Commit message

Port sqlvalues and co to postgres E'strings', rather than relying on standard_conforming_strings=off.

Description of the change

Port sqlvalues and co to postgres E'strings', rather than relying on standard_conforming_strings=off. They also now escape ' as \' rather than '', mostly so people can lazily paste them into Python and not get insane results.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Yup.

psycopg2 can do some of this if you know where to look, but this implementation is simpler and easier to maintain than the alternative.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.