Launchpad itself

Merge lp://staging/~wgrant/launchpad/no-lucilleconfig-stayofexecution into lp://staging/launchpad

  1. no-lucilleconfig-stayofexecution
  2. Merge into devel
Proposed by William Grant
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 12109
Proposed branch: lp://staging/~wgrant/launchpad/no-lucilleconfig-stayofexecution
Merge into: lp://staging/launchpad
Prerequisite: lp://staging/~wgrant/launchpad/no-lucilleconfig-directories
Diff against target: 253 lines (+17/-39)
7 files modified
lib/lp/archivepublisher/config.py (+0/-8)
lib/lp/archivepublisher/deathrow.py (+0/-1)
lib/lp/archivepublisher/domination.py (+12/-8)
lib/lp/archivepublisher/publishing.py (+1/-1)
lib/lp/archivepublisher/tests/publisher-config.txt (+0/-7)
lib/lp/archivepublisher/tests/test_config.py (+0/-6)
lib/lp/archivepublisher/tests/test_dominator.py (+4/-8)
To merge this branch: bzr merge lp://staging/~wgrant/launchpad/no-lucilleconfig-stayofexecution
Reviewer Review Type Date Requested Status
Tim Penhey (community) mentor Approve
Steve Kowalik (community) code* Approve
Review via email: mp+38653@code.staging.launchpad.net

Commit message

[r=stevenk][ui=none][bug=692056] Hardcode the publisher's stay of execution to one day, rather than reading it from lucilleconfig.

Description of the change

Another stage of my anti-lucilleconfig tirade, this branch obsoletes Distribution.lucilleconfig's pendingremovalduration key.

As suggested in https://bugs.launchpad.net/soyuz/+bug/45270/comments/6, the stay of execution is now hardcoded to one day. Dominator no longer has any use for its config, so it has been unthreaded.

To post a comment you must log in.
Revision history for this message
Steve Kowalik (stevenk) wrote :

Hi William,

My one concern with this branch is what the production config is set to with regards to stay of execution. Other than that, this looks good.

review: Approve (code*)
Revision history for this message
William Grant (wgrant) wrote :

The code was originally set to 5 days, but the production config was set to 1. So I've changed the code also say 1.

Revision history for this message
Tim Penhey (thumper) :
review: Approve (mentor)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.