Launchpad itself

Merge lp://staging/~wgrant/launchpad/launchpadtargetwidget-prefix-respect into lp://staging/launchpad

  1. launchpadtargetwidget-prefix-respect
  2. Merge into devel
Proposed by William Grant
Status: Merged
Merged at revision: 13530
Proposed branch: lp://staging/~wgrant/launchpad/launchpadtargetwidget-prefix-respect
Merge into: lp://staging/launchpad
Diff against target: 73 lines (+22/-5)
2 files modified
lib/lp/app/widgets/doc/launchpad-target-widget.txt (+14/-0)
lib/lp/app/widgets/launchpadtarget.py (+8/-5)
To merge this branch: bzr merge lp://staging/~wgrant/launchpad/launchpadtargetwidget-prefix-respect
Reviewer Review Type Date Requested Status
Steve Kowalik (community) code Approve
Review via email: mp+69187@code.staging.launchpad.net

Commit message

Fix LaunchpadTargetWidget to not set up its subwidgets in __init__, as the prefix isn't set by then.

Description of the change

LaunchpadTargetWidget presently creates its subwidgets in __init__. This is OK for Answers, the sole current user, because it doesn't do anything special like set a custom prefix. But views that want a custom prefix set it after __init__, so it doesn't the subwidgets do not inherit it. In the case of BugTaskEditView, this means that the widgets for each task have conflicting names and IDs.

To post a comment you must log in.
Revision history for this message
Steve Kowalik (stevenk) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.