Merge lp://staging/~wgrant/launchpad/get-translations-jobs-working into lp://staging/launchpad
Proposed by
William Grant
| Status: | Merged |
|---|---|
| Approved by: | Jelmer Vernooij |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~wgrant/launchpad/get-translations-jobs-working |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
199 lines (+57/-13) 6 files modified
database/schema/security.cfg (+1/-0) lib/canonical/buildd/tests/test_translationtemplatesbuildmanager.py (+13/-2) lib/canonical/buildd/translationtemplates.py (+4/-2) lib/lp/testing/fakemethod.py (+11/-5) lib/lp/translations/model/translationtemplatesbuildbehavior.py (+1/-1) lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+27/-3) |
| To merge this branch: | bzr merge lp://staging/~wgrant/launchpad/get-translations-jobs-working |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeroen T. Vermeulen (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Fix the few remaining issues with translation template builds.
Description of the change
This branch fixes the last few issues that are preventing translation template builds from running end-to-end.
- The slave used os.path.join() with the absolute home directory path as the second argument, which meant that the chroot part of the path was ignored.
- The slave called addWaiting, when the correct name is addWaitingFile.
- buildd-manager needed permission to create and update TranslationImpo
- The build behaviour was forgetting to pass the branch when calling its own _uploadTarball method.
To post a comment you must log in.
Revision history for this message
| Jeroen T. Vermeulen (jtv) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for extending the tests to cover your changes. Very comforting to know that tarball upload is now integration-tested. At the time of writing, just one more tiny change needed: a full stop at the end of the assertion string.