Merge lp://staging/~wgrant/launchpad/bug-692114-recipes-main-component into lp://staging/launchpad

Proposed by William Grant
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 12112
Proposed branch: lp://staging/~wgrant/launchpad/bug-692114-recipes-main-component
Merge into: lp://staging/launchpad
Diff against target: 42 lines (+10/-4)
2 files modified
lib/lp/code/model/sourcepackagerecipebuild.py (+4/-4)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+6/-0)
To merge this branch: bzr merge lp://staging/~wgrant/launchpad/bug-692114-recipes-main-component
Reviewer Review Type Date Requested Status
Tim Penhey (community) code Approve
Steve Kowalik (community) code* Approve
Review via email: mp+44184@code.staging.launchpad.net

Commit message

[r=stevenk,thumper][ui=none][bug=692114] Recipe builds now always build in main, since PPAs only have indices for main.

Description of the change

SourcePackageRecipeBuild.current_component is now always multiverse. Recipes only build into PPAs, and PPAs only support main, so multiverse is always wrong. New PPAs don't even have indices for the other components, so recipe builds fail!

This will need to become more dynamic when we start building recipes into other archive types, but for now setting it to main will work fine. Note that this does not affect the component used by the primary archive dependency.

To post a comment you must log in.
Revision history for this message
Steve Kowalik (stevenk) wrote :

After a discussion with William about this change, I'm happy with it.

review: Approve (code*)
Revision history for this message
Tim Penhey (thumper) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.