Merge lp://staging/~wgrant/launchpad/bug-685624-ttbj-build-interface into lp://staging/launchpad

Proposed by William Grant
Status: Merged
Approved by: Данило Шеган
Approved revision: no longer in the source branch.
Merged at revision: 12143
Proposed branch: lp://staging/~wgrant/launchpad/bug-685624-ttbj-build-interface
Merge into: lp://staging/launchpad
Diff against target: 44 lines (+6/-2)
3 files modified
lib/lp/buildmaster/interfaces/buildfarmbranchjob.py (+4/-0)
lib/lp/translations/configure.zcml (+1/-1)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+1/-1)
To merge this branch: bzr merge lp://staging/~wgrant/launchpad/bug-685624-ttbj-build-interface
Reviewer Review Type Date Requested Status
Данило Шеган (community) code Approve
Review via email: mp+44558@code.staging.launchpad.net

Commit message

[r=danilo][ui=none][bug=685624] Let TranslationTemplatesBuildJob.build through the security proxy.

Description of the change

TranslationTemplatesBuildJob.build was recently added, but security declarations were not updated to permit access to it. This branch fixes that by adding IBuildFarmBranchJob['build'].

It would be more correct to instead add IBuildFarmJobOld['build'], but that is more trouble than fixing this obsolete model is worth.

I've updated a test to check that the attribute is accessible through the security proxy.

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) :
review: Approve (blessing)
Revision history for this message
Данило Шеган (danilo) wrote :

ec2 land seems to be agnostic: believe I say, believe!

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.