Merge lp://staging/~wgrant/launchpad/bug-592935-hide-disabled-ppas into lp://staging/launchpad
Proposed by
William Grant
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Māris Fogels | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 11017 | ||||
| Proposed branch: | lp://staging/~wgrant/launchpad/bug-592935-hide-disabled-ppas | ||||
| Merge into: | lp://staging/launchpad | ||||
| Diff against target: |
72 lines (+20/-24) 2 files modified
lib/lp/soyuz/stories/ppa/xx-ppa-workflow.txt (+18/-20) lib/lp/soyuz/templates/person-ppas.pt (+2/-4) |
||||
| To merge this branch: | bzr merge lp://staging/~wgrant/launchpad/bug-592935-hide-disabled-ppas | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Māris Fogels (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Hide non-Viewable PPAs from the person index. This prevents normal users from seeing others' disabled PPAs
Description of the change
Normal users are currently able to see the disabled and deleted PPAs of others on their index pages (eg. https:/
This is pointless, confusing, makes deletion look like a joke, and generally annoys users. As far as I can tell it is unintentional, as others I've talked to weren't aware that it was the case.
The fix is simple: just check for launchpad.View on the PPA, since that's revoked from non-owners when a PPA is disabled or deleted. This also has the side-effect of removing an empty <tr> which was in the place of invisible private PPAs.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi William,
A huge +1 from me for fixing this. You are right, the previous behaviour was bad. A nice, small, clean fix.
I'll assume you will run the full suite before landing this. You never know what other tests may unintentionally depend on the PPA link listing.
r=mars
Maris