Merge lp://staging/~wgrant/launchpad/bug-522800-getFileByName into lp://staging/launchpad

Proposed by William Grant
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 12043
Proposed branch: lp://staging/~wgrant/launchpad/bug-522800-getFileByName
Merge into: lp://staging/launchpad
Diff against target: 332 lines (+113/-140)
5 files modified
lib/lp/soyuz/doc/build-files.txt (+7/-136)
lib/lp/soyuz/model/archive.py (+1/-0)
lib/lp/soyuz/stories/ppa/xx-ppa-files.txt (+2/-2)
lib/lp/soyuz/tests/test_archive.py (+100/-0)
lib/lp/testing/factory.py (+3/-2)
To merge this branch: bzr merge lp://staging/~wgrant/launchpad/bug-522800-getFileByName
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+43159@code.staging.launchpad.net

Commit message

Archive.getFileByName now returns only unexpired files.

Description of the change

Archive.getFileByName currently doesn't care if the file it returns is expired. That isn't excellent, since an expired file is just about useless. This branch fixes it to only return unexpired files, fixing bug #522800. It also happens to fix bug #687662, a 10.12 regression that was just discovered.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Turn the doctest change into a unit test and r=me

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Looks good, I shall land it.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Except - there's a failing test!
Please fix xx-ppa-files.txt

kthxbye

review: Needs Fixing
Revision history for this message
William Grant (wgrant) wrote :

The test is fixed.

Revision history for this message
Julian Edwards (julian-edwards) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.