Merge lp://staging/~wgrant/bzr-builder/bug-1242796 into lp://staging/bzr-builder
Proposed by
William Grant
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 174 | ||||
| Proposed branch: | lp://staging/~wgrant/bzr-builder/bug-1242796 | ||||
| Merge into: | lp://staging/bzr-builder | ||||
| Prerequisite: | lp://staging/~wgrant/bzr-builder/bug-1350430 | ||||
| Diff against target: |
31 lines (+6/-4) 2 files modified
cmds.py (+5/-3) tests/test_blackbox.py (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~wgrant/bzr-builder/bug-1242796 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Approve | ||
| bzr-builder developers | Pending | ||
|
Review via email:
|
|||
Commit message
Fix --no-build to leave a PACKAGE-VERSION directory rather than a TEMPLATE directory, returning to the 0.7.2 behaviour.
Description of the change
Fix --no-build to leave a PACKAGE-VERSION directory rather than a TEMPLATE directory. This regressed in r158. It technically breaks compatibility with 0.7.3 by returning to the 0.7.2 behaviour, but I doubt anything actually wants the broken 0.7.3 behaviour
21:51:45 < jelmer> oh, right
21:51:50 < jelmer> yeah, that's not intentional
To post a comment you must log in.
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
Revision history for this message
| Colin Watson (cjwatson) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
On Wed, Aug 06, 2014 at 12:17:23PM -0000, William Grant wrote:
> William Grant has proposed merging lp:~wgrant/bzr-builder/bug-1242796 into lp:bzr-builder with lp:~wgrant/bzr-builder/bug-1350430 as a prerequisite.
>
> Commit message:
> Fix --no-build to leave a PACKAGE-VERSION directory rather than a TEMPLATE directory, returning to the 0.7.2 behaviour.
>
> Requested reviews:
> bzr-builder developers (bzr-builder-devs)
> Related bugs:
> Bug #1242796 in bzr-builder: "Fix destdir for recipe"
> https:/
>
> For more details, see:
> https:/
>
> Fix --no-build to leave a PACKAGE-VERSION directory rather than a TEMPLATE directory. This regressed in r158. It technically breaks compatibility with 0.7.3 by returning to the 0.7.2 behaviour, but I doubt anything actually wants the broken 0.7.3 behaviour
>
> 21:51:45 < jelmer> oh, right
> 21:51:50 < jelmer> yeah, that's not intentional
Fix LGTM.
Jelmer