Merge lp://staging/~wesmason/charms/trusty/mongodb/merge-precise-patches into lp://staging/charms/trusty/mongodb

Proposed by Wes Mason
Status: Merged
Merged at revision: 65
Proposed branch: lp://staging/~wesmason/charms/trusty/mongodb/merge-precise-patches
Merge into: lp://staging/charms/trusty/mongodb
Diff against target: 111 lines (+58/-1)
5 files modified
.bzrignore (+1/-0)
charm-helpers-sync.yaml (+1/-0)
hooks/charmhelpers/payload/__init__.py (+1/-0)
hooks/charmhelpers/payload/execd.py (+50/-0)
hooks/hooks.py (+5/-1)
To merge this branch: bzr merge lp://staging/~wesmason/charms/trusty/mongodb/merge-precise-patches
Reviewer Review Type Date Requested Status
Matt Bruzek (community) Approve
Review Queue (community) automated testing Needs Fixing
Adam Israel (community) Approve
Review via email: mp+237694@code.staging.launchpad.net

Commit message

Merge exec.d and volume relation_id patches from precise charm

Description of the change

This adds in the exec.d and volumes relation_id (MP#234670) patches from the precise mongodb charm.

To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #809 trusty-mongodb for wesmason mp237694
    LINT FAIL: lint-check missing

LINT Results not found.
Build: http://10.98.191.181:8080/job/charm_lint_check/809/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #617 trusty-mongodb for wesmason mp237694
    UNIT FAIL: unit-test missing

UNIT Results not found.
Build: http://10.98.191.181:8080/job/charm_unit_test/617/

Revision history for this message
Adam Israel (aisrael) wrote :

Hi Wes,

Thanks for the work bringing over patches from the precise branch. I've had the opportunity to review this MP and am happy to report that it tests successfully. I'm adding my +1.

review: Approve
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10911-results

review: Needs Fixing (automated testing)
Revision history for this message
Matt Bruzek (mbruzek) wrote :

There were some lint errors that I took care of to avoid delaying this merge. In the future please resolve the lint errors in the files that you touch, even if you did not introduce them.

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: