Juju Charms Collection
mongodb package

Merge lp://staging/~wesmason/charms/precise/mongodb/add-storage-subordinate-support into lp://staging/charms/mongodb

Proposed by Wes Mason on 2014-06-18

Status:	Merged
Merged at revision:	49
Proposed branch:	lp://staging/~wesmason/charms/precise/mongodb/add-storage-subordinate-support
Merge into:	lp://staging/charms/mongodb
Diff against target:	206 lines (+98/-4) 4 files modified README.md (+18/-2) config.yaml (+4/-1) hooks/hooks.py (+72/-1) metadata.yaml (+4/-0)
To merge this branch:	bzr merge lp://staging/~wesmason/charms/precise/mongodb/add-storage-subordinate-support
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Stuart Bishop (community)		2014-06-18	Approve on 2014-07-29
Review via email: mp+223539@code.staging.launchpad.net

Description of the change

This adds support for the storage subordinate as a way to automatically handle attaching/mounting volumes from both OpenStack and AWS EBS, by using the data- relation hooks to setup a /srv/juju/mongodb-data mount which is then used by the existing volume management code to symlink in place and rsync any existing MongoDB data over, similar to the way the postgres charm works with the subordinate.

We need this internally to support automated Mongo-on-persistent-volume deploys with juju-deployer.

Revision history for this message

Wes Mason (wesmason) wrote on 2014-06-18:

Bug 1206468 is related to this.

Revision history for this message

Stuart Bishop (stub) wrote on 2014-07-29:

This all seems good to me.

The charm could be tidied up with support of charmhelpers, eg. using @hooks.hook instead of the if/then statement to invoke the correct hook handler. But that is unrelated to this branch, which is nicely contained and doesn't want the scope creep.

review: Approve