unity-js-scopes

Merge lp://staging/~webapps/unity-js-scopes/fix-npm-build into lp://staging/unity-js-scopes

  1. fix-npm-build
  2. Merge into trunk
Proposed by Marcus Tomlinson
Status: Merged
Approved by: Marcus Tomlinson
Approved revision: 87
Merged at revision: 85
Proposed branch: lp://staging/~webapps/unity-js-scopes/fix-npm-build
Merge into: lp://staging/unity-js-scopes
Prerequisite: lp://staging/~abreu-alexandre/unity-js-scopes/remove-factory-new-constructs
Diff against target: 79 lines (+41/-7)
1 file modified
src/tool/main.cc (+41/-7)
To merge this branch: bzr merge lp://staging/~webapps/unity-js-scopes/fix-npm-build
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+274371@code.staging.launchpad.net

Commit message

Detect current arch for unity-js-scopes-tool build.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:84
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/5/rebuild

review: Approve (continuous-integration)
lp://staging/~webapps/unity-js-scopes/fix-npm-build updated
85. By Marcus Tomlinson

Merged remove-factory-new-constructs

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

A small comment

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:85
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/6/rebuild

review: Approve (continuous-integration)
lp://staging/~webapps/unity-js-scopes/fix-npm-build updated
86. By Marcus Tomlinson

Added better error checking to get_arch() call

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

> A small comment

fixed

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:86
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/10/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/10/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/10/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~webapps/unity-js-scopes/fix-npm-build updated
87. By Marcus Tomlinson

Merged trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:87
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/11/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/11/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/11
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/11/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/11

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/11/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: