Merge ~waveform/ubuntu-release-upgrader:remove-uboot into ubuntu-release-upgrader:ubuntu/master
Proposed by
Dave Jones
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 36ed0aa86545ab59e44cb12eea07574f39f36d24 | ||||
Proposed branch: | ~waveform/ubuntu-release-upgrader:remove-uboot | ||||
Merge into: | ubuntu-release-upgrader:ubuntu/master | ||||
Diff against target: |
467 lines (+379/-34) 3 files modified
DistUpgrade/DistUpgradeQuirks.py (+137/-1) debian/changelog (+7/-0) tests/test_quirks.py (+235/-33) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brian Murray | Needs Fixing | ||
Review via email: mp+406663@code.staging.launchpad.net |
Commit message
Adds a quirk to remote u-boot from the boot sequence of Raspberry Pi installations on impish. This doesn't remove the u-boot binaries themselves, and leaves the actual configuration commented out in the config.txt in case user's wish to revert easily.
LP: #1936401
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
I found the function _remove_ uboot_on_ rpi a bit hard to read and had to scroll up and down multiple times because the file is read, then some other functions are defined, and then the file is passed to those functions. It might be easier for others to read if that was restructured a bit.
I can't really comment on the correctness of the boot config contents but as a release upgrader quirk this seems good to me.
I've some additional comments in-line.