Launchpad itself

Merge lp://staging/~wallyworld/launchpad/recipe-buildnow-permission into lp://staging/launchpad

recipe-buildnow-permission
Merge into devel

Proposed by Ian Booth on 2011-04-28

Status:

Merged

Approved by:

Ian Booth on 2011-04-28

Approved revision:

no longer in the source branch.

Merged at revision:

12951

Proposed branch:

lp://staging/~wallyworld/launchpad/recipe-buildnow-permission

Merge into:

lp://staging/launchpad

Diff against target:

42 lines (+13/-1)

2 files modified

lib/lp/code/browser/sourcepackagerecipe.py (+2/-1)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+11/-0)

To merge this branch:

bzr merge lp://staging/~wallyworld/launchpad/recipe-buildnow-permission

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
j.c.sackett (community)		2011-04-28	Approve on 2011-04-28
Review via email: mp+59380@code.staging.launchpad.net

Commit message

[r=jcsackett][bug=769762] Do not show recipe build now if user does not have edit permission on recipe.

Description of the change

Do not show recipe build now if user does not have edit permission on recipe.

== Implementation ==

Small tweak to request_daily_build() on SourcePackageRecipeContextMenu - check for recipe edit permission.

== Tests ==

Add new test test_request_daily_builds_button_no_recipe_permission() to TestSourcePackageRecipeView

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
lib/lp/code/browser/sourcepackagerecipe.py
lib/lp/code/browser/tests/test_sourcepackagerecipe.py

./lib/lp/code/browser/tests/test_sourcepackagerecipe.py
     483: E501 line too long (80 characters)
    1101: E501 line too long (85 characters)
    1131: E501 line too long (85 characters)
    1166: E501 line too long (85 characters)
     238: Line exceeds 78 characters.
     483: Line exceeds 78 characters.
    1101: Line exceeds 78 characters.
    1131: Line exceeds 78 characters.
    1153: Line exceeds 78 characte