Merge lp://staging/~wallyworld/launchpad/recipe-build-filter-fix into lp://staging/launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12081 | ||||
Proposed branch: | lp://staging/~wallyworld/launchpad/recipe-build-filter-fix | ||||
Merge into: | lp://staging/launchpad | ||||
Diff against target: |
146 lines (+70/-33) 2 files modified
lib/lp/code/browser/tests/test_recipebuildslisting.py (+44/-6) lib/lp/code/templates/daily-builds-listing.pt (+26/-27) |
||||
To merge this branch: | bzr merge lp://staging/~wallyworld/launchpad/recipe-build-filter-fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Review via email: mp+43770@code.staging.launchpad.net |
Commit message
[r=thumper]
Description of the change
= Summary =
There are 2 issues with the recent recipe build page:
1. the distribution is listed for each record but at the moment it's always Ubuntu (the distribution should be removed)
2. when the filter widget is used and there are no records, the widget disappears (it should remain)
= Implementation =
Issue 1 - remove the distribution rendering from the page template
Issue 2 - move the "no records" <div> in the page template file so the filter control is always rendered
= Tests =
test -vvt test_recipebuil
Added a new test - test_recentbuil
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
merge approved