Merge lp://staging/~wallyworld/launchpad/latest-builds-failed-recipe-build into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Leonard Richardson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12311 |
Proposed branch: | lp://staging/~wallyworld/launchpad/latest-builds-failed-recipe-build |
Merge into: | lp://staging/launchpad |
Diff against target: |
165 lines (+58/-28) 5 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+5/-1) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+7/-5) lib/lp/code/model/recipebuild.py (+1/-21) lib/lp/code/model/sourcepackagerecipe.py (+4/-1) lib/lp/services/database/stormexpr.py (+41/-0) |
To merge this branch: | bzr merge lp://staging/~wallyworld/launchpad/latest-builds-failed-recipe-build |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonard Richardson (community) | Approve | ||
Review via email:
|
Commit message
[r=leonardr]
Description of the change
The query used to load the recipe build jobs was broken because it allowed failed builds to hang around at the top of the recent builds list and never expire. Details are in the bug 680733
== Implementation ==
Modify the getBuilds() query order by expression to order by greatest(
An extension to Storm was required - Storm does not provide a greatest() function. This was added into a new file lp.services.
== Tests ==
lp.code.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
389: E501 line too long (80 characters)
886: E501 line too long (85 characters)
916: E501 line too long (85 characters)
951: E501 line too long (85 characters)
389: Line exceeds 78 characters.
886: Line exceeds 78 characters.
916: Line exceeds 78 characters.
938: Line exceeds 78 characters.
951: Line exceeds 78 characters.
./lib/lp/
21: E302 expected 2 blank lines, found 1
28: E302 expected 2 blank lines, found 1