Merge lp://staging/~wallyworld/launchpad/disabled-archive-recipe-oops into lp://staging/launchpad

Proposed by Ian Booth
Status: Merged
Approved by: Данило Шеган
Approved revision: no longer in the source branch.
Merged at revision: 12823
Proposed branch: lp://staging/~wallyworld/launchpad/disabled-archive-recipe-oops
Merge into: lp://staging/launchpad
Diff against target: 97 lines (+69/-0)
2 files modified
lib/lp/code/model/sourcepackagerecipebuild.py (+7/-0)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+62/-0)
To merge this branch: bzr merge lp://staging/~wallyworld/launchpad/disabled-archive-recipe-oops
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Review via email: mp+57421@code.staging.launchpad.net

Commit message

[r=danilo][bug=751958] A simple change to stop the make_daily_builds script throw an exception (and hence oopsing) when there are issues with the recipe's daily build archive.

Description of the change

== Implementation ==

A simple change to stop the make_daily_builds script throw an exception (and hence oopsing) when there are issues with the recipe's daily build archive. Like is done for the case when there is already a build pending, the exception is caught, a message is logged, and the script continues.

== Tests ==

Add some tests to lp/code/model/tests/test_sourcepackagerecipebuild.py
  test_makeDailyBuilds_skips_builds_already_queued
  test_makeDailyBuilds_skips_disabled_archive
  test_makeDailyBuilds_skips_archive_with_no_permission

The first test above should have been written earlier when the functionality was first done but appears to have been missed out. So I added that and also tests for cases where daily builds were done on recipes with archive issues.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/model/sourcepackagerecipebuild.py
  lib/lp/code/model/tests/test_sourcepackagerecipebuild.py

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.