Launchpad itself

Merge lp://staging/~wallyworld/launchpad/advanced-bug-search-model-915880 into lp://staging/launchpad

  1. advanced-bug-search-model-915880
  2. Merge into devel
Proposed by Ian Booth
Status: Merged
Approved by: Curtis Hovey
Approved revision: no longer in the source branch.
Merged at revision: 16109
Proposed branch: lp://staging/~wallyworld/launchpad/advanced-bug-search-model-915880
Merge into: lp://staging/launchpad
Diff against target: 280 lines (+72/-115)
2 files modified
lib/lp/bugs/browser/bugtask.py (+3/-1)
lib/lp/bugs/browser/tests/test_bugtask.py (+69/-114)
To merge this branch: bzr merge lp://staging/~wallyworld/launchpad/advanced-bug-search-model-915880
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+128401@code.staging.launchpad.net

Commit message

Do not populate bug model cache for advanced search form.

Description of the change

== Implementation ==

Add a check to the BugTaskSearchListingView initiaisation so that if the advanced form is being used, do not render the bug model in the json cache.

== Tests ==

Refacator some common tests to a mixin and add a new test for the new advanced for behaviour.

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/browser/bugtask.py
  lib/lp/bugs/browser/tests/test_bugtask.py

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.