Merge lp://staging/~wallyworld/juju-core/watcher-address-issues into lp://staging/~go-bot/juju-core/trunk

Proposed by Ian Booth
Status: Superseded
Proposed branch: lp://staging/~wallyworld/juju-core/watcher-address-issues
Merge into: lp://staging/~go-bot/juju-core/trunk
Diff against target: 164 lines (+82/-19)
3 files modified
state/machine.go (+19/-11)
state/megawatcher.go (+25/-8)
state/megawatcher_internal_test.go (+38/-0)
To merge this branch: bzr merge lp://staging/~wallyworld/juju-core/watcher-address-issues
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+213967@code.staging.launchpad.net

Description of the change

Ensure unit addresses populated

Change the internals of the megawatcher to ensure
that machine addresses are correct and that the
public and private addresses for untis come from
the assigned machine.

https://codereview.appspot.com/80370044/

To post a comment you must log in.
Revision history for this message
Ian Booth (wallyworld) wrote :

Reviewers: mp+213967_code.launchpad.net,

Message:
Please take a look.

Description:
Ensure unit addresses populated

Change the internals of the megawatcher to ensure
that machine addresses are correct and that the
public and private addresses for untis come from
the assigned machine.

https://code.launchpad.net/~wallyworld/juju-core/watcher-address-issues/+merge/213967

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/80370044/

Affected files (+84, -19 lines):
   A [revision details]
   M state/machine.go
   M state/megawatcher.go
   M state/megawatcher_internal_test.go

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: