Go Windows Azure Client Library

Merge lp://staging/~wallyworld/gwacl/storage-error-not-panic into lp://staging/gwacl

  1. storage-error-not-panic
  2. Merge into trunk
Proposed by Ian Booth
Status: Merged
Approved by: Ian Booth
Approved revision: 220
Merged at revision: 224
Proposed branch: lp://staging/~wallyworld/gwacl/storage-error-not-panic
Merge into: lp://staging/gwacl
Diff against target: 221 lines (+53/-27)
4 files modified
shared_signature.go (+13/-7)
shared_signature_test.go (+6/-3)
storage_base.go (+25/-13)
storage_base_test.go (+9/-4)
To merge this branch: bzr merge lp://staging/~wallyworld/gwacl/storage-error-not-panic
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+184704@code.staging.launchpad.net

Commit message

GetAnonymousFileURL() was panicing if there was an issue. I changed it to return an error. This is because juju sometimes needs to try and find a URL of a file but it doesn't know if it exists or not. So by using error and not panic, juju can handle the situation accordingly.

Description of the change

GetAnonymousFileURL() was panicing if there was an issue. I changed it to return an error. This is because juju sometimes needs to try and find a URL of a file but it doesn't know if it exists or not. So by using error and not panic, juju can handle the situation accordingly.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

make format required.

Otherwise looks good.

review: Approve
Revision history for this message
Go Bot (go-bot) wrote :

The attempt to merge lp:~wallyworld/gwacl/storage-error-not-panic into lp:gwacl failed. Below is the output from the failed tests.

./utilities/format -s

retry_policy.go:7:5: cannot find package "launchpad.net/gwacl/fork/http" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gwacl/fork/http (from $GOROOT)
 /home/tarmac/trees/gwacl-trees/src/launchpad.net/gwacl/fork/http (from $GOPATH)
x509session.go:9:5: cannot find package "launchpad.net/gwacl/fork/tls" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gwacl/fork/tls (from $GOROOT)
 /home/tarmac/trees/gwacl-trees/src/launchpad.net/gwacl/fork/tls (from $GOPATH)
storage.go:14:5: cannot find package "launchpad.net/gwacl/logging" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gwacl/logging (from $GOROOT)
 /home/tarmac/trees/gwacl-trees/src/launchpad.net/gwacl/logging (from $GOPATH)
example/management/run.go:15:5: cannot find package "launchpad.net/gwacl" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gwacl (from $GOROOT)
 /home/tarmac/trees/gwacl-trees/src/launchpad.net/gwacl (from $GOPATH)

Revision history for this message
Go Bot (go-bot) wrote :

The attempt to merge lp:~wallyworld/gwacl/storage-error-not-panic into lp:gwacl failed. Below is the output from the failed tests.

./utilities/format -s
FAIL launchpad.net/gwacl [build failed]
FAIL launchpad.net/gwacl/dedent [build failed]
? launchpad.net/gwacl/example/management [no test files]
? launchpad.net/gwacl/example/storage [no test files]
? launchpad.net/gwacl/fork/http [no test files]
? launchpad.net/gwacl/fork/tls [no test files]
FAIL launchpad.net/gwacl/logging [build failed]

# launchpad.net/gwacl/dedent
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/dedent/dedent_test.go:7: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]
# launchpad.net/gwacl/logging
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/logging/logging_test.go:7: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]
# launchpad.net/gwacl
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/deletedisk_test.go:8: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]

Revision history for this message
Go Bot (go-bot) wrote :

The attempt to merge lp:~wallyworld/gwacl/storage-error-not-panic into lp:gwacl failed. Below is the output from the failed tests.

./utilities/format -s
FAIL launchpad.net/gwacl [build failed]
FAIL launchpad.net/gwacl/dedent [build failed]
? launchpad.net/gwacl/example/management [no test files]
? launchpad.net/gwacl/example/storage [no test files]
? launchpad.net/gwacl/fork/http [no test files]
? launchpad.net/gwacl/fork/tls [no test files]
FAIL launchpad.net/gwacl/logging [build failed]

# launchpad.net/gwacl/dedent
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/dedent/dedent_test.go:7: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]
# launchpad.net/gwacl/logging
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/logging/logging_test.go:7: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]
# launchpad.net/gwacl
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/deletedisk_test.go:8: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]

Revision history for this message
Go Bot (go-bot) wrote :

The attempt to merge lp:~wallyworld/gwacl/storage-error-not-panic into lp:gwacl failed. Below is the output from the failed tests.

./utilities/format -s
FAIL launchpad.net/gwacl [build failed]
FAIL launchpad.net/gwacl/dedent [build failed]
? launchpad.net/gwacl/example/management [no test files]
? launchpad.net/gwacl/example/storage [no test files]
? launchpad.net/gwacl/fork/http [no test files]
? launchpad.net/gwacl/fork/tls [no test files]
FAIL launchpad.net/gwacl/logging [build failed]

# launchpad.net/gwacl/dedent
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/dedent/dedent_test.go:7: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]
# launchpad.net/gwacl/logging
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/logging/logging_test.go:7: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]
# launchpad.net/gwacl
../../../../trees/gwacl-trees/src/launchpad.net/gwacl/deletedisk_test.go:8: import /home/tarmac/trees/gwacl-trees/pkg/linux_amd64/launchpad.net/gocheck.a: object is [linux amd64 go1.1.1 X:none] expected [linux amd64 go1.1.2 X:none]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: