Merge lp://staging/~wallyworld/gwacl/prefix-service-match into lp://staging/gwacl
| Status: | Rejected |
|---|---|
| Rejected by: | Ian Booth |
| Proposed branch: | lp://staging/~wallyworld/gwacl/prefix-service-match |
| Merge into: | lp://staging/gwacl |
| Diff against target: |
119 lines (+52/-17) 2 files modified
management.go (+14/-2) management_test.go (+38/-15) |
| To merge this branch: | bzr merge lp://staging/~wallyworld/gwacl/prefix-service-match |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrew Wilkins (community) | Approve | ||
|
Review via email:
|
|||
Commit message
When finding services using a prefix match, it was possible to accidentally include additional unwanted services in the result. This branch allows a separator to be specified when invoking the ListPrefixedHos
Thus if a separator of "-" is specified with a prefix of "azure", then:
azure-service will match
azure-1-service will not match
Description of the change
When finding services using a prefix match, it was possible to accidentally include additional unwanted services in the result. This branch allows a separator to be specified when invoking the ListPrefixedHos
Thus if a separator of "-" is specified with a prefix of "azure", then:
azure-service will match
azure-1-service will not match
Feels like kind of a weird overloading; I kinda think we'd be better off just ditching the use of ListPrefixedHos
But... LGTM, I don't want to hold up the fix.