Go Windows Azure Client Library

Merge lp://staging/~wallyworld/gwacl/fix-request-eof-2 into lp://staging/gwacl

  1. fix-request-eof-2
  2. Merge into trunk
Proposed by Ian Booth
Status: Merged
Approved by: Ian Booth
Approved revision: 228
Merged at revision: 228
Proposed branch: lp://staging/~wallyworld/gwacl/fix-request-eof-2
Merge into: lp://staging/gwacl
Diff against target: 61 lines (+15/-8)
3 files modified
retry_policy.go (+0/-8)
storage_base.go (+11/-0)
x509session.go (+4/-0)
To merge this branch: bzr merge lp://staging/~wallyworld/gwacl/fix-request-eof-2
Reviewer Review Type Date Requested Status
Ian Booth Approve
Review via email: mp+193346@code.staging.launchpad.net

Commit message

The first fix for the request eof issue worked by setting
Close=true on the http request. This seemed to be not always
work so a different approach is used (same as for goose).
Set DisableKeepAlives=true on the http transport.

Description of the change

Fix request eof #2

The first fix for the request eof issue worked by setting
Close=true on the http request. This seemed to be not always
work so a different approach is used (same as for goose).
Set DisableKeepAlives=true on the http transport.

To post a comment you must log in.
Revision history for this message
Ian Booth (wallyworld) wrote :

Please take a look.

lp://staging/~wallyworld/gwacl/fix-request-eof-2 updated
228. By Ian Booth

Ensure all transports have DisableKeepAlives=true

Revision history for this message
Julian Edwards (julian-edwards) wrote :

This is to much Go-fu for me to really understand what's going on.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

*too* much, even

Revision history for this message
Ian Booth (wallyworld) wrote :

Self approving as this is the same solution as used for goose and juju-core.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: