Merge lp://staging/~wallyworld/golxc/support-cmd-env into lp://staging/golxc

Proposed by Ian Booth
Status: Merged
Approved by: Ian Booth
Approved revision: 15
Merged at revision: 13
Proposed branch: lp://staging/~wallyworld/golxc/support-cmd-env
Merge into: lp://staging/golxc
Diff against target: 812 lines (+203/-160)
4 files modified
golxc.go (+18/-15)
golxc_test.go (+181/-141)
network.go (+3/-3)
package_test.go (+1/-1)
To merge this branch: bzr merge lp://staging/~wallyworld/golxc/support-cmd-env
Reviewer Review Type Date Requested Status
Andrew Wilkins (community) Approve
Review via email: mp+242438@code.staging.launchpad.net

Commit message

Add support for passing environment variables to the container Create command. This can potentially be added to other commands too, but for now is just needed for Create().

Also, the gocheck import was out of date, so was updated.

Description of the change

Add support for passing environment variables to the container Create command. This can potentially be added to other commands too, but for now is just needed for Create().

Also, the gocheck import was out of date, so was updated.

To post a comment you must log in.
Revision history for this message
Andrew Wilkins (axwalk) wrote :

LGTM with comments addressed.

review: Approve
Revision history for this message
Ian Booth (wallyworld) :
14. By Ian Booth

Enahnce test

15. By Ian Booth

Improve comment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: