Merge lp://staging/~waldner/terminator/fast-resize into lp://staging/terminator/gtk3

Proposed by Waldner
Status: Needs review
Proposed branch: lp://staging/~waldner/terminator/fast-resize
Merge into: lp://staging/terminator/gtk3
Diff against target: 395 lines (+159/-18)
8 files modified
doc/terminator_config.5 (+20/-0)
terminatorlib/config.py (+5/-0)
terminatorlib/container.py (+1/-1)
terminatorlib/notebook.py (+1/-1)
terminatorlib/paned.py (+13/-7)
terminatorlib/preferences.glade (+80/-3)
terminatorlib/prefseditor.py (+22/-1)
terminatorlib/terminal.py (+17/-5)
To merge this branch: bzr merge lp://staging/~waldner/terminator/fast-resize
Reviewer Review Type Date Requested Status
Terminator Pending
Review via email: mp+341534@code.staging.launchpad.net

Commit message

Add new option for fast-resizing. Update glade and man page.

Description of the change

Add new option for fast-resizing. Update glade and man page.
Discussion at https://bugs.launchpad.net/terminator/+bug/1695935.

To post a comment you must log in.
Revision history for this message
Waldner (waldner) wrote :

Any news on this?

Revision history for this message
Bryce Harrington (bryce) wrote :

> Any news on this?

I would recommend not to use the shift+arrow key combos. I suspect the reason they're unused is because for some people and some keyboards that combo is hit a lot accidentally. If alt+ctrl+shift+arrow is unused by anything, that might be a safer default.

As I think Stephen already mentioned, it's hard to find unused key combos for Terminator, so wise to avoid adding new ones unless absolutely necessary.

If the need for this patch is primarily due to need for configuring your terminal layout on startup, it may be overall better to look at creating a profile with pre-defined terminal window layouts. I can explain how to do this if that's your use case.

In the first comment of the bug report, the idea was floated to make the resize amount for ctrl+shift+arrow configurable. Would that satisfy your requirements? If so, it may be a way to avoid using up key combos.

Revision history for this message
Waldner (waldner) wrote :

After a bit of experimenting, I settled on the separate keyboard shortcut for fast resize because I wanted to be able to alternate regular (slow) and fast resizing as needed, depending on what I'm doing.
Also, using a preset configuration to be applied at terminal startup doesn't work for me, since I keep splitting/removing windows all the time and the need to do a fast resize at a given moment is dictated by the task I'm actually performing (eg, I need to quickly resize to better see a long log line, but then I resize back just as quickly).

Shift+arrow keys is what works for me, and as far as I can see it's unused in terminator (as per terminatorlib/config.py). I can certainly change the default to alt+ctrl+shift+arrow (also unused), if that helps to have a better change of merging.

1796. By Waldner

Safer default keyboard shortcuts for fast resize function, as per discussion
at https://code.launchpad.net/~waldner/terminator/fast-resize/+merge/341534

Revision history for this message
Waldner (waldner) wrote :

FWIW, here's the safer default of <Ctrl><Shift><Alt><arrow> implemented.

Revision history for this message
Waldner (waldner) wrote :

Is there anything else that should be done to get this in shape?

Unmerged revisions

1796. By Waldner

Safer default keyboard shortcuts for fast resize function, as per discussion
at https://code.launchpad.net/~waldner/terminator/fast-resize/+merge/341534

1795. By Waldner

New "fast resize" functionality, updated glade and man page.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: