Merge lp://staging/~waigani/juju-core/suspend-resume-local-plugin into lp://staging/~go-bot/juju-core/trunk

Proposed by Jesse Meek
Status: Work in progress
Proposed branch: lp://staging/~waigani/juju-core/suspend-resume-local-plugin
Merge into: lp://staging/~go-bot/juju-core/trunk
Prerequisite: lp://staging/~thumper/juju-core/local-update-template
Diff against target: 149 lines (+117/-0) (has conflicts)
4 files modified
cmd/plugins/local/main.go (+2/-0)
cmd/plugins/local/main_test.go (+3/-0)
cmd/plugins/local/resume.go (+56/-0)
cmd/plugins/local/suspend.go (+56/-0)
Text conflict in cmd/plugins/local/main.go
To merge this branch: bzr merge lp://staging/~waigani/juju-core/suspend-resume-local-plugin
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+212743@code.staging.launchpad.net

Description of the change

Local plugins suspend, resume

Add two plugins to the local provider: suspend and resume.
This branch sets up the boilerplate and help docs for the plugins.
The functionality of suspend and resume will be added in a later
branch once the following branch is landed:
lp:~waigani/juju-core/add-start-stop-to-container-manager-interface

https://codereview.appspot.com/80160043/

To post a comment you must log in.
Revision history for this message
Jesse Meek (waigani) wrote :

Reviewers: mp+212743_code.launchpad.net,

Message:
Please take a look.

Description:
Local plugins suspend, resume

Add two plugins to the local provider: suspend and resume.
This branch sets up the boilerplate and help docs for the plugins.
The functionality of suspend and resume will be added in a later
branch once the following branch is landed:
lp:~waigani/juju-core/add-start-stop-to-container-manager-interface

https://code.launchpad.net/~waigani/juju-core/suspend-resume-local-plugin/+merge/212743

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/80160043/

Affected files (+119, -0 lines):
   A [revision details]
   M cmd/plugins/local/main.go
   M cmd/plugins/local/main_test.go
   A cmd/plugins/local/resume.go
   A cmd/plugins/local/suspend.go

Revision history for this message
Andrew Wilkins (axwalk) wrote :

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/resume.go
File cmd/plugins/local/resume.go (right):

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/resume.go#newcode21
cmd/plugins/local/resume.go:21: resume starts the specified container
that has previously been shutdown.
s/shutdown/suspended/
?

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/resume.go#newcode23
cmd/plugins/local/resume.go:23: If the container is kvm, resume will
execute "virsh start <container- name>".
Does the user really care about this? Seems a bit low-level to me.
If you do keep it, s/container- name/container-name/

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/resume.go#newcode55
cmd/plugins/local/resume.go:55: return nil
Perhaps return an error saying not implemented.

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/suspend.go
File cmd/plugins/local/suspend.go (right):

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/suspend.go#newcode23
cmd/plugins/local/suspend.go:23: If the container is kvm, suspend will
execute "virsh destroy <container-
Again, this seems too low-level for user docs.

https://codereview.appspot.com/80160043/

Revision history for this message
William Reade (fwereade) wrote :

LGTM as a skeleton, but please don't land do-nothing commands (or at
least make sure they're not accessible)

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/suspend.go
File cmd/plugins/local/suspend.go (right):

https://codereview.appspot.com/80160043/diff/1/cmd/plugins/local/suspend.go#newcode23
cmd/plugins/local/suspend.go:23: If the container is kvm, suspend will
execute "virsh destroy <container-
On 2014/03/26 01:20:31, axw wrote:
> Again, this seems too low-level for user docs.

Agreed. Would be really nice to put this sort of thing in the actual
documentation somewhere, though...

https://codereview.appspot.com/80160043/

Revision history for this message
William Reade (fwereade) wrote :

WIP to keep queue tidy

Unmerged revisions

2419. By Jesse Meek

Add suspend and resume plugins to the local provider

2418. By Tim Penhey

Use the new function.

2417. By Tim Penhey

Merged local-ensure-root into local-update-template.

2416. By Tim Penhey

Merged pipe-base into local-update-template.

2415. By Tim Penhey

More scaffolding

2414. By Tim Penhey

Merged pipe-base into local-update-template.

2413. By Tim Penhey

boilerplate

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: