Rhythmbox

Merge lp://staging/~vuhieple/rhythmbox/plugin-lyrics into lp://staging/rhythmbox

  1. plugin-lyrics
  2. Merge into trunk
Proposed by Le Vu Hiep
Status: Needs review
Proposed branch: lp://staging/~vuhieple/rhythmbox/plugin-lyrics
Merge into: lp://staging/rhythmbox
Diff against target: 222 lines (+187/-8)
3 files modified
plugins/lyrics/LyricsSites.py (+9/-8)
plugins/lyrics/MaxiParser.py (+82/-0)
plugins/lyrics/ZingParser.py (+96/-0)
To merge this branch: bzr merge lp://staging/~vuhieple/rhythmbox/plugin-lyrics
Reviewer Review Type Date Requested Status
Jonathan Matthew Disapprove
Review via email: mp+92809@code.staging.launchpad.net

Description of the change

I added two working parsers for the lyrics plugin and edited the LyricsSites.py to include those ones.

To post a comment you must log in.
Revision history for this message
Jonathan Matthew (jmatthew) wrote :

Thanks, but I don't accept patches this way. Please open a bug in GNOME bugzilla and attach a patch there.

Also, it appears you've based your changes to LyricsSites.py on an old version of the file. Please make sure you base your changes on the current code.

review: Disapprove
Reply

Unmerged revisions

7879. By Le Vu Hiep

Some new parsers for rhythmbox fetching Vietnamese and English lyrics)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: