Ubuntu Terminal App

Merge lp://staging/~vthompson/ubuntu-terminal-app/fix-1380812 into lp://staging/ubuntu-terminal-app

fix-1380812
Merge into trunk

Proposed by Victor Thompson on 2014-11-11

Status:

Merged

Approved by:

Alan Pope 🍺🐧🐱 🦄 on 2015-01-29

Approved revision:

176

Merged at revision:

192

Proposed branch:

lp://staging/~vthompson/ubuntu-terminal-app/fix-1380812

Merge into:

lp://staging/ubuntu-terminal-app

Diff against target:

35 lines (+15/-2)

1 file modified

src/app/qml/ubuntu-terminal-app.qml (+15/-2)

To merge this branch:

bzr merge lp://staging/~vthompson/ubuntu-terminal-app/fix-1380812

Related bugs:

Bug #1288343: On Flo (n7 2013) the terminal text input line is above the header	High	Fix Released
Bug #1380812: Rotating phone on nexus 4 causes terminal to overwrite header	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-11-19
Filippo Scognamiglio		2014-11-11	Approve on 2014-11-11
Alan Pope 🍺🐧🐱 🦄		2014-11-11	Pending
Review via email: mp+241376@code.staging.launchpad.net

Commit message

* Call header hide or show when changing orientation.

Description of the change

Also call header hide or show when changing orientation.

Could someone also verify that lp:1288343 is fixed with this change? Adding popey as a required reviewer.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-11-11:

PASSED: Continuous integration, rev:175
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/120/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/136
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/136/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/4

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/120/rebuild

review: Approve (continuous-integration)

Revision history for this message

Filippo Scognamiglio (flscogna) on 2014-11-11:

review: Approve

lp://staging/~vthompson/ubuntu-terminal-app/fix-1380812 updated on 2014-11-19

176. By Victor Thompson on 2014-11-19: Seemingly fix the header being covered when the app is started on a Nexus 7, need to know why

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-11-19:

I was able to verify the fix for lp:1288343 on my Nexus 7, however, the behavior in lp:1380812 occurs when the app is started--without rotating the screen on the Nexus 7. I've added a work around for this, but this I'm not sure why the work around fixes the issue.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-11-19:

PASSED: Continuous integration, rev:176
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/121/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/288
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/288/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/5