Ubuntu Music App

Merge lp://staging/~vthompson/music-app/sort-songs-tab-by-date into lp://staging/music-app

  1. sort-songs-tab-by-date
  2. Merge into trunk
Proposed by Victor Thompson
Status: Rejected
Rejected by: Victor Thompson
Proposed branch: lp://staging/~vthompson/music-app/sort-songs-tab-by-date
Merge into: lp://staging/music-app
Diff against target: 53 lines (+27/-0)
3 files modified
app/components/Themes/Ambiance/PageHeadStyle.qml (+7/-0)
app/music-app.qml (+3/-0)
app/ui/Songs.qml (+17/-0)
To merge this branch: bzr merge lp://staging/~vthompson/music-app/sort-songs-tab-by-date
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Music App Developers Pending
Review via email: mp+260906@code.staging.launchpad.net

Commit message

Sort songs tab by date modified/added.

Description of the change

Sort songs tab by date modified/added.

This is a WIP at the moment. The other views, unfortunately, do not use models that seem to have a way of being sorted by date added.

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

#blocked by design or community input

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:863
http://91.189.93.70:8080/job/music-app-ci/1305/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2873
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2873/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/399
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/157

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1305/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~vthompson/music-app/sort-songs-tab-by-date updated
864. By Victor Thompson

Translate section headings

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:864
http://91.189.93.70:8080/job/music-app-ci/1306/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2877
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2877/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/400
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/158

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1306/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Think we need to investigate page head sections vs head actions as well. Otherwise looks interesting, I wonder what other sorting methods we should have, these should be explored when doing convergence.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:864
http://91.189.93.70:8080/job/music-app-ci/1311/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/163

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1311/rebuild

review: Approve (continuous-integration)

Unmerged revisions

864. By Victor Thompson

Translate section headings

863. By Victor Thompson

Sort songs tab by date modified/added.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches