Ubuntu Music App

Merge lp://staging/~vthompson/music-app/recent-items into lp://staging/music-app/trusty

recent-items
Merge into trusty

Proposed by Victor Thompson on 2013-10-17

Status:

Merged

Approved by:

Victor Thompson on 2013-10-22

Approved revision:

226

Merged at revision:

229

Proposed branch:

lp://staging/~vthompson/music-app/recent-items

Merge into:

lp://staging/music-app/trusty

Diff against target:

350 lines (+176/-23)

6 files modified

LibraryListModel.qml (+19/-0)
MusicAlbums.qml (+4/-0)
MusicPlaylists.qml (+5/-2)
MusicStart.qml (+65/-20)
meta-database.js (+75/-1)
music-app.qml (+8/-0)

To merge this branch:

bzr merge lp://staging/~vthompson/music-app/recent-items

Related bugs:

Bug #1238801: [Music app] Single genre / artist layout	High	Fix Released
Bug #1238834: [Music app] Albums / genres on the Music tab should link to an album or genre	Medium	Fix Released
Bug #1240335: [Music app] Should "Recent" just say "Albums"	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Andrew Hayzen		2013-10-17	Approve on 2013-10-22
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2013-10-20
Review via email: mp+191738@code.staging.launchpad.net

Commit message

* Add database schema to track recent items
* Change models to query selected playlist or album
* Update recent list when an album or playlist is selected from either its tab or the recent list

Description of the change

* Add database schema to track recent items
* Change models to query selected playlist or album
* Update recent list when an album or playlist is selected from either its tab or the recent list

Note, that this change does not implement the sheet pattern for the items in the Recent list. That will need to be implemented at a later time.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2013-10-17:

PASSED: Continuous integration, rev:222
http://91.189.93.70:8080/job/music-app-ci/272/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/1153
    SUCCESS: http://91.189.93.70:8080/job/music-app-precise-amd64-ci/272
    SUCCESS: http://91.189.93.70:8080/job/music-app-quantal-amd64-ci/272
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/272
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/274

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/272/rebuild

review: Approve (continuous-integration)

lp://staging/~vthompson/music-app/recent-items updated on 2013-10-18

223. By Victor Thompson on 2013-10-18: Show recent list as empty instead of hiding it when it is empty

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2013-10-18:

PASSED: Continuous integration, rev:223
http://91.189.93.70:8080/job/music-app-ci/273/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/1154
    SUCCESS: http://91.189.93.70:8080/job/music-app-precise-amd64-ci/273
    SUCCESS: http://91.189.93.70:8080/job/music-app-quantal-amd64-ci/273
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/273
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/275

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/273/rebuild

review: Approve (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2013-10-19:

Could I get someone to review this? If you want to toggle back to the empty state with no recent items do the following:
1) uncomment L222 of meta-database.js in the reset function.
2) start the app and then kill it
3) re-comment L222

lp://staging/~vthompson/music-app/recent-items updated on 2013-10-19

224. By Victor Thompson on 2013-10-19: Add a button to clear history.
225. By Victor Thompson on 2013-10-19: Fix button visibility

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2013-10-19:

PASSED: Continuous integration, rev:225
http://91.189.93.70:8080/job/music-app-ci/276/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/1164
    SUCCESS: http://91.189.93.70:8080/job/music-app-precise-amd64-ci/276
    SUCCESS: http://91.189.93.70:8080/job/music-app-quantal-amd64-ci/276
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/276
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/278

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/276/rebuild

review: Approve (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2013-10-19:

I implemented a clear button (not in the design spec) that I found useful.

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2013-10-20:

Looks good, I think we need to talk to design regarding the clear button (I guess if we had the setting page it could go in there? but we don't at the moment).

Also on the first run I noticed I got this error.
meta-database.js:329: Error: no such table: recent Unable to execute statement

lp://staging/~vthompson/music-app/recent-items updated on 2013-10-20

226. By Victor Thompson on 2013-10-20: Resolve warning upon initialization.

Revision history for this message

Victor Thompson (vthompson) wrote on 2013-10-20:

I see that error as well, but when the app starts to load content and isRecentEmpty() is called before the table exists it was designed to return true in all cases but when entries were found. I've fixed the issue, however.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2013-10-20:

PASSED: Continuous integration, rev:226
http://91.189.93.70:8080/job/music-app-ci/277/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/1165
    SUCCESS: http://91.189.93.70:8080/job/music-app-precise-amd64-ci/277
    SUCCESS: http://91.189.93.70:8080/job/music-app-quantal-amd64-ci/277
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/277
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/279