Ubuntu Music App

Merge lp://staging/~vthompson/music-app/music-maximize-artwork into lp://staging/music-app

  1. music-maximize-artwork
  2. Merge into trunk
Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 904
Merged at revision: 906
Proposed branch: lp://staging/~vthompson/music-app/music-maximize-artwork
Merge into: lp://staging/music-app
Diff against target: 24 lines (+2/-1)
2 files modified
app/components/NowPlayingFullView.qml (+1/-1)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp://staging/~vthompson/music-app/music-maximize-artwork
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+269460@code.staging.launchpad.net

Commit message

* Always fit the cover art to vertically fill the BlurredBackground

Description of the change

* Always fit the cover art to vertically fill the BlurredBackground

This makes it so phone/narrow view doesn't show a blurred bg when the app is more narrow. This results in some minor clipping in "narrow" or phone mode, but that seems preferable.

To post a comment you must log in.
lp://staging/~vthompson/music-app/music-maximize-artwork updated
904. By Victor Thompson

update

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:903
http://91.189.93.70:8080/job/music-app-ci/1370/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/222

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1370/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:904
http://91.189.93.70:8080/job/music-app-ci/1371/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/223

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1371/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Surely this comes at the cost of the left/right of the image being cut on small device width in proportion to the height and then just creates gaps on the left/right of the image when you have a large device width in proportion to the height?

Before it would be optimal for both cases, now it just seems to be optimised for one case but compromised for others. Maybe a "fill" would be better so instead ensure that the longer side is always filled, this would then remove the gaps in both cases (long/short height/width). As in the code snippet below.

size: parent.width > parent.height ? parent.width : parent.height

review: Needs Information
Revision history for this message
Victor Thompson (vthompson) wrote :

I think we should "compromise" the image on narrow screens--so the artwork takes up the full space--and show the blurred background on the sides for wide screens. If the code change you suggest is used, the cover art is probably *too* compromised on the desktop.

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

After further discussions, this looks good for the mobile view, table/desktop views will be solved once the converged layouts land.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches