Ubuntu Music App

Merge lp://staging/~vthompson/music-app/improve-playlist-delete into lp://staging/music-app/remix

  1. improve-playlist-delete
  2. Merge into remix
Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 862
Merged at revision: 857
Proposed branch: lp://staging/~vthompson/music-app/improve-playlist-delete
Merge into: lp://staging/music-app/remix
Diff against target: 58 lines (+7/-17)
2 files modified
common/SongsPage.qml (+2/-11)
playlists.js (+5/-6)
To merge this branch: bzr merge lp://staging/~vthompson/music-app/improve-playlist-delete
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+255237@code.staging.launchpad.net

Commit message

Improve multiselect delete for playlist items

Description of the change

Improve multiselect delete for playlist items

To post a comment you must log in.
lp://staging/~vthompson/music-app/improve-playlist-delete updated
858. By Victor Thompson

Remove returns

859. By Victor Thompson

Remove returns

860. By Victor Thompson

Remove returns

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:857
http://91.189.93.70:8080/job/music-app-ci/1291/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2505
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2505/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/385
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/143

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1291/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:860
http://91.189.93.70:8080/job/music-app-ci/1292/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2506
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2506/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/386
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/144

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1292/rebuild

review: Approve (continuous-integration)
lp://staging/~vthompson/music-app/improve-playlist-delete updated
861. By Victor Thompson

reuse removeFromPlaylist()

862. By Victor Thompson

Execute within a single transaction.

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

This is now super quick :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:862
http://91.189.93.70:8080/job/music-app-ci/1293/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2510
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2510/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/387
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/145

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1293/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches