Ubuntu Music App

Merge lp://staging/~vthompson/music-app/fix-1445158 into lp://staging/music-app/remix

fix-1445158
Merge into remix

Proposed by Victor Thompson on 2015-04-18

Status:

Rejected

Rejected by:

Victor Thompson on 2015-10-25

Proposed branch:

lp://staging/~vthompson/music-app/fix-1445158

Merge into:

lp://staging/music-app/remix

Diff against target:

58 lines (+15/-1)

2 files modified

Player.qml (+13/-1)
music-app.qml (+2/-0)

To merge this branch:

bzr merge lp://staging/~vthompson/music-app/fix-1445158

Wishlist

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2015-04-18
Music App Developers		2015-04-18	Pending
Review via email: mp+256741@code.staging.launchpad.net

Commit message

* Save position in currently playing song

Description of the change

* Save position in currently playing song

The Component.onDestruction signal won't work reliably to detect when to set a saved position--and at the moment it doesn't seem to work at all. However, a solution that would work perfectly while the app is not being suspended is to save the position when the position value changes (once a second). This solution will not be perfect when the app is able to be suspended, however, a few other things will need a similar solution including the queueIndex. I think we should and will be able to accommodate them both (queueIndex and the new savedPosition).

Currently when the source is loaded the duration is not detected, so the saved position can not be loaded/seeked to until the song is played.

lp://staging/~vthompson/music-app/fix-1445158 updated on 2015-04-18