Merge lp://staging/~vthompson/music-app/fix-1365247 into lp://staging/music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 614
Merged at revision: 614
Proposed branch: lp://staging/~vthompson/music-app/fix-1365247
Merge into: lp://staging/music-app/trusty
Diff against target: 22 lines (+5/-3)
1 file modified
tests/autopilot/music_app/content/mediascanner-2.0/mediastore.sql (+5/-3)
To merge this branch: bzr merge lp://staging/~vthompson/music-app/fix-1365247
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+233303@code.staging.launchpad.net

Commit message

Update AP tests to newest mediascanner 2.0 db schema version.

Description of the change

Update AP tests to newest mediascanner 2.0 db schema version.

DO NOT LAND UNTIL THE VERSION OF MEDIASCANNER 2.0 IN THE BUG REPORT HAS LANDED!

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

New Package is in the archive, setting to Review.

http://packages.ubuntu.com/utopic/mediascanner2.0

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Ok this fails on my VM with unable to play /home/phablet/Music/1.ogg (note my home is /home/andy/).

This is due to the following code not being run because _patch_mediascanner_home() is not called.

relhome = self.home_dir[1:]
dblocation = "home/phablet"
# patch mediaindex
self._file_find_replace(mediascannerpath +
                        "/mediastore.sql", dblocation, relhome)

review: Needs Fixing
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
614. By Victor Thompson

Fix sql file

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Awesome :) One day we won't have to chase upstream...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: