Ubuntu Music App

Merge lp://staging/~vthompson/music-app/fix-1332570-test_next_previous into lp://staging/music-app/trusty

  1. fix-1332570-test_next_previous
  2. Merge into trusty
Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 501
Merged at revision: 499
Proposed branch: lp://staging/~vthompson/music-app/fix-1332570-test_next_previous
Merge into: lp://staging/music-app/trusty
Diff against target: 47 lines (+15/-0)
3 files modified
MusicToolbar.qml (+1/-0)
tests/autopilot/music_app/emulators.py (+11/-0)
tests/autopilot/music_app/tests/test_music.py (+3/-0)
To merge this branch: bzr merge lp://staging/~vthompson/music-app/fix-1332570-test_next_previous
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+223985@code.staging.launchpad.net

Commit message

* Update test_next_previous to seek to 0 before selecting previous

Description of the change

This appears to fail because the song isn't being paused quick enough after hitting the Next button. Thus, when Previous is being selected the time the track has been playing is over 5 seconds so the track starts over. This change causes the track to pause immediately (or close to immediately).

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:499
http://91.189.93.70:8080/job/music-app-ci/884/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/592
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/592/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/108

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/884/rebuild

review: Approve (continuous-integration)
lp://staging/~vthompson/music-app/fix-1332570-test_next_previous updated
500. By Victor Thompson

Seek to 0 prior to selecting previous

501. By Victor Thompson

Fix pep8

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:500
http://91.189.93.70:8080/job/music-app-ci/885/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/593/console
    FAILURE: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/109/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/885/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:501
http://91.189.93.70:8080/job/music-app-ci/886/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/594
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/594/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/110

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/886/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Hopefully should resolve the issue :)

And passes on mako locally for me:
00:17:28.789 INFO testresult:46 - OK: music_app.tests.test_music.TestMainWindow.test_next_previous(with touch)

Ran 1 test in 78.110s
OK

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: