Ubuntu Music App

Merge lp://staging/~vthompson/music-app/change-header-in-now-playing-queue into lp://staging/music-app/remix

change-header-in-now-playing-queue
Merge into remix

Proposed by Victor Thompson on 2015-01-30

Status:	Work in progress
Proposed branch:	lp://staging/~vthompson/music-app/change-header-in-now-playing-queue
Merge into:	lp://staging/music-app/remix
Diff against target:	36 lines (+13/-2) 2 files modified MusicNowPlaying.qml (+11/-0) music-app.qml (+2/-2)
To merge this branch:	bzr merge lp://staging/~vthompson/music-app/change-header-in-now-playing-queue
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2015-01-30
Music App Developers		2015-01-30	Pending
Review via email: mp+248076@code.staging.launchpad.net

Commit message

* Change header color when in Now Playing or Queue to black.

Description of the change

* Change header color when in Now Playing or Queue to black.

After using the app with the newer full-cover Now Playing view, it's gotten a bit odd to have a grey header in this view, and in the Queue. I had played with changing the header to black earlier, but I think I dropped the attempt because it didn't seem to perform well. Or maybe the overflow action drawer wasn't conforming to the color change. Either way, it seems to work OK now.

Additionally, this will fit in nicely when the bottom edge capability arrives.

This will need some design review.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-01-30:

PASSED: Continuous integration, rev:821
http://91.189.93.70:8080/job/music-app-ci/1268/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/897
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/897/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/120

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1268/rebuild

review: Approve (continuous-integration)

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2015-02-01:

Still not sure about this change, as we discussed before. Also I get loads of these in the console with this branch.

file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/MainView.qml:202:5: QML StyledItem: Binding loop detected for property "style"
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml:70:5: QML Binding: Binding loop detected for property "target"