Merge lp://staging/~vthompson/music-app/bigger-play-button into lp://staging/music-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 884
Merged at revision: 884
Proposed branch: lp://staging/~vthompson/music-app/bigger-play-button
Merge into: lp://staging/music-app
Diff against target: 21 lines (+2/-2)
1 file modified
app/components/MusicToolbar.qml (+2/-2)
To merge this branch: bzr merge lp://staging/~vthompson/music-app/bigger-play-button
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+264143@code.staging.launchpad.net

Commit message

Make play/pause button in the toolbar larger.

Description of the change

Make play/pause button in the toolbar larger.

The new icon resources for "media-playback-pause" and "media-playback-play" appear a bit smaller than before at the size the toolbar was using them. This MP has the play button a bit larger than the play button was in the toolbar previously.

Previously with new resources: http://i.imgur.com/CeHf3Ij.png

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:884
http://91.189.93.70:8080/job/music-app-ci/1338/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/190

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1338/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, I've also gone through the other icons used and they all look ok. Landing this now so it can be in the click for OTA5ish :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches