Merge lp://staging/~vthompson/music-app/albums-bottom-offset-1234963 into lp://staging/music-app/trusty

Proposed by Victor Thompson
Status: Rejected
Rejected by: Victor Thompson
Proposed branch: lp://staging/~vthompson/music-app/albums-bottom-offset-1234963
Merge into: lp://staging/music-app/trusty
Diff against target: 12 lines (+1/-1)
1 file modified
MusicAlbums.qml (+1/-1)
To merge this branch: bzr merge lp://staging/~vthompson/music-app/albums-bottom-offset-1234963
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Music App Developers Pending
Review via email: mp+191746@code.staging.launchpad.net

Commit message

Allow bottom margin on Albums tab to not cause the toolbar to overlap the cover art

Description of the change

Allow bottom margin on Albums tab to not cause the toolbar to overlap the cover art

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lisette Slegers (lisette-slegers) wrote :

See https://docs.google.com/a/canonical.com/presentation/d/1nc7RTAD5ViEAdc3VsZyN-lkmG-AnO664uV-5wXZoZZg/edit#slide=id.ge8e1d63f_074

There is no empty space on any of the screens and the toolbar, when revealed, overlaps items on the screen.

Unmerged revisions

221. By Victor Thompson

Allow bottom margin on Albums tab to not cause the toolbar to overlap the cover art

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: